schema: Add error checking on remote schema files#400
Draft
michaelwood wants to merge 1 commit intomainfrom
Draft
schema: Add error checking on remote schema files#400michaelwood wants to merge 1 commit intomainfrom
michaelwood wants to merge 1 commit intomainfrom
Conversation
When fetching and downloading we can get some obscure messages that are hard to distinguish between input data errors and configuration errors. (As seen with recent threesixtygiving test coves). This captures errors and rewords them to be more helpful.
michaelwood
force-pushed
the
mw/schema_parser_exception_on_http_error
branch
from
f2709b1 to
01e8e09
Compare
Member
Author
|
Slightly unclear on replacing the assert here https://github.com/OpenDataServices/flatten-tool/blob/main/flattentool/tests/test_schema_parser.py#L755 |
Member
|
Yeah, not quite sure why it's like that. It seems to be doing 2 things at once. Can you replace with a test that the reffing works for a 200, and a test that your errors are thrown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching and downloading we can get some obscure messages that are hard to distinguish between input data errors and configuration errors. (As seen with recent threesixtygiving test coves). This captures errors and rewords them to be more helpful.